[PATCH] D142396: [AArch64] Add the Ampere1A core

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492
+    {"ampere1a", ARMV8_6A,
+     (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 |
+      AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES |
----------------
Just to check, you didn't mention SM4 in the commit message or the gcc patch from https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605942.html. Should that be included here?


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:1166
+def TuneAmpere1A : SubtargetFeature<"ampere1a", "ARMProcFamily", "Ampere1A",
+				    "Ampere Computing Ampere-1A processors", [
+				    FeaturePostRAScheduler,
----------------
Formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142396/new/

https://reviews.llvm.org/D142396