[PATCH] D142227: [RISCV][LSR] Treat number of instructions as dominate factor in LSR cost decisions

Tue Jan 24 08:29:17 PST 2023

reames added a comment.

In D142227#4077351 <https://reviews.llvm.org/D142227#4077351>, @asb wrote:

> It looks like we might want to consider, in a followup patch, also implementing `isNumRegsMajorCostOfLSR` to returning false (introduced in D89665 <https://reviews.llvm.org/D89665>)?

I looked at that, but only one target actually uses it.  The actual use doesn't seem to match the naming; it seems to in practice mean "turn off chain detection".  I don't think we want to do that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142227/new/

https://reviews.llvm.org/D142227