[PATCH] D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 14:43:43 PST 2023


beanz added a comment.

In D96670#4074988 <https://reviews.llvm.org/D96670#4074988>, @aaronpuchert wrote:

> Yeah, I don't usually do this. But this has been sitting for a very long time with a couple of pings and no attention.

The review didn't have great reviewers selected. Adding additional reviewers or pinging people on Discord would have been a better approach. I often lose track of commit emails, but respond better to IM pings.

In D96670#4074988 <https://reviews.llvm.org/D96670#4074988>, @aaronpuchert wrote:

> Thanks for the hint! I thought there must be an easier way, but you can find this pattern all over the code. Maybe you can have a look at D142405 <https://reviews.llvm.org/D142405>. It was a bit tedious and only covers `llvm/cmake` for now. But it definitely reads a lot better.

Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96670/new/

https://reviews.llvm.org/D96670



More information about the llvm-commits mailing list