[PATCH] D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS

Aaron Puchert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 14:36:16 PST 2023


aaronpuchert added a comment.

Yeah, I don't usually do this. But this has been sitting for a very long time with a couple of pings and no attention.

In D96670#4072350 <https://reviews.llvm.org/D96670#4072350>, @beanz wrote:

> In terms of the change itself, the logic looks fine, but you should use the CMake “if(NOT … IN_LIST …)” formulation instead of find and checking indexes. It is more concise and more clearly expresses what you’re doing.

Thanks for the hint! I thought there must be an easier way, but you can find this pattern all over the code. Maybe you can have a look at D142405 <https://reviews.llvm.org/D142405>. It was a bit tedious and only covers `llvm/cmake` for now. But it definitely reads a lot better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96670/new/

https://reviews.llvm.org/D96670



More information about the llvm-commits mailing list