[PATCH] D142215: [MC] Define and use MCInstrDesc implicit_uses and implicit_defs. NFC.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 23 06:27:03 PST 2023
foad added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:1942
ResultReg)
- .addReg(II.getImplicitDefs()[0]);
}
----------------
arsenm wrote:
> Just taking the first implicit def looks suspect to me. I'd expect something like MachineInstrBuilder::copyImplicitOps for an MCInstrDesc
This goes back a long way: rGe775d3526c2e6ec4785906b14aedc4dccd6e3d49
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142215/new/
https://reviews.llvm.org/D142215
More information about the llvm-commits
mailing list