[PATCH] D142215: [MC] Define and use MCInstrDesc implicit_uses and implicit_defs. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 06:19:58 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/MC/MCInstrDesc.cpp:33
 bool MCInstrDesc::hasImplicitDefOfPhysReg(unsigned Reg,
                                           const MCRegisterInfo *MRI) const {
+  for (MCPhysReg ImpDef : implicit_defs())
----------------
arsenm wrote:
> Using MRI when that's usually MachineRegisterInfo is a bit jarring. This API that doesn't work correctly if you don't pass it in is also just broken
Massive patch to rename MRI to MCRI for MCRegisterInfo throughout llvm/: D142356


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142215/new/

https://reviews.llvm.org/D142215



More information about the llvm-commits mailing list