[PATCH] D141891: [VP][DAGCombiner] Introduce generalized pattern match for vp sdnodes.

Mon Jan 23 01:53:59 PST 2023

frasercrmck added inline comments.

================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1348
+/// Translate this VP Opcode to its corresponding non-VP Opcode.
+std::optional<unsigned> getFunctionOpcodeForVP(unsigned Opcode,
+                                               bool hasFPExcept);
----------------
I'm not mad about the term "function opcode" - it doesn't sound right to me. I don't have a better suggestion right now though. I'm just commenting this in case other people feel similarly.

================
Comment at: llvm/test/CodeGen/RISCV/rvv/fold-vp-fadd-and-vp-fmul.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -mattr=+v -target-abi=lp64d -verify-machineinstrs < %s | FileCheck %s
----------------
Pre-committing this test would be nice, as it'd allow us to better see the changes this patch allows us.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141891/new/

https://reviews.llvm.org/D141891