[PATCH] D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

Woah!

“I can’t find someone to review this so I’m just going to merge it” is not okay.

I apologize for not reviewing it earlier, but c’mon… that’s not how the community operates.

In terms of the change itself, the logic looks fine, but you should use the CMake “if(NOT … IN_LIST …)” formulation instead of find and checking indexes. It is more concise and more clearly expresses what you’re doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96670/new/

https://reviews.llvm.org/D96670