[PATCH] D142323: [Kaleidoscope] Update code snippets in text to match full code listings

[Dhruv Chawla via Phabricator via llvm-commits]

0xdc03 created this revision.
Herald added a project: All.
0xdc03 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

There were quite a few places in the tutorial where the snippets were
not up to date with the full code listings given. I have updated all of
the ones I could find, which mostly involves changing `.` to `->` when
accessing through a `std::unique_ptr`, changing `while (1)` to `while
(true)`, and other such small changes.

There are still however a few places where I am not sure what to do,
such as:

- Chapter 4: `ParseTopLevelExpr()` in chapter 3 sets the ProtoTypeAST name to "", however it is referred to as "__anon_expr" in chapter 4. Would it be required to mention this change in chapter 4?
- Chapter 9: The code snippets refer to the top level expression as "main", however the full code listing refers to it as "__anon_expr". I think given the context of the chapter it makes sense to refer to it as "main", so I have updated the code listing to reflect that.
- Chapter 9: In chapter 9 the diff given for `HandleTopLevelExpression()` deletes code that is not mentioned anywhere else, so I am not sure what is to be done there.
- Miscellaneous: I don't think this is very important, however the casing used for the first word of error messages tends to vary between upper and lower case between chapters and I do not know if it is worth reconciling these differences.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142323

Files:
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl06.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl07.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl08.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl09.rst
  llvm/examples/Kaleidoscope/Chapter9/toy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142323.491226.patch
Type: text/x-patch
Size: 32023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230123/ad8e4944/attachment.bin>