[PATCH] D142292: [SCEV] Introduce `SCEVSelectExpr`

Sun Jan 22 18:30:09 PST 2023

lebedev.ri added a comment.

In D142292#4072244 <https://reviews.llvm.org/D142292#4072244>, @lebedev.ri wrote:

> In D142292#4072222 <https://reviews.llvm.org/D142292#4072222>, @efriedma wrote:
>
>> My primary concern here is compile-time; in general, the more complex expressions we model, the more we have to worry about SCEV going out of control in complex cases.
>
> True, that seems to be The concern for SCEV.

This has an unreasonably small compile-time impact:
https://llvm-compile-time-tracker.com/compare.php?from=0cdf030cf8dcfb8bfe551c16b14a29e124497069&to=832e0fd5f8a1ecedc64e414627ad8641d70d2682&stat=instructions:u
... while having //some// `size-total` changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142292/new/

https://reviews.llvm.org/D142292