[PATCH] D142298: [AVR] Emit 'eicall' for devices with large program memory

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 22 13:53:24 PST 2023


aykevl accepted this revision.
aykevl added a comment.
This revision is now accepted and ready to land.

Looks good to me.

The inline assembly is perhaps a bit confusing. What I would do is split this function into two functions: one returns `@func` as a function pointer, and the other with a single function pointer parameter that is called. Feel free to do that or leave as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142298/new/

https://reviews.llvm.org/D142298



More information about the llvm-commits mailing list