[PATCH] D142308: [Polly] Fix a if condition in isl_coalesce.ci

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 22 08:35:41 PST 2023


xgupta created this revision.
xgupta added reviewers: Meinersbur, aeubanks.
Herald added a reviewer: bollu.
Herald added a project: All.
xgupta requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

info->bmap is a pointer to an isl_basic_map struct and n_eq is a
member of that struct, which represents the number of equality
constraints in the basic map. It should not be less than zero.
Previously it waas performing  "pointer < 0" check.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142308

Files:
  polly/lib/External/isl/isl_coalesce.c


Index: polly/lib/External/isl/isl_coalesce.c
===================================================================
--- polly/lib/External/isl/isl_coalesce.c
+++ polly/lib/External/isl/isl_coalesce.c
@@ -3178,7 +3178,7 @@
 			return isl_stat_error;
 		info->bmap = isl_basic_map_cow(info->bmap);
 		info->bmap = isl_basic_map_free_inequality(info->bmap, 2 * n);
-		if (info->bmap < 0)
+		if (info->bmap->n_eq < 0)
 			return isl_stat_error;
 
 		return fix_constant_divs(info, n, expanded);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142308.491170.patch
Type: text/x-patch
Size: 488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230122/f6b42849/attachment.bin>


More information about the llvm-commits mailing list