[llvm] 418f780 - [NFC][SCEV] Reflow `computeSCEVAtScope()` into an exhaustive switch

[Roman Lebedev via llvm-commits]

Author: Roman Lebedev
Date: 2023-01-22T17:48:49+03:00
New Revision: 418f780f1f882dbe4f72fcbd3b24b2ce34520557

URL: https://github.com/llvm/llvm-project/commit/418f780f1f882dbe4f72fcbd3b24b2ce34520557
DIFF: https://github.com/llvm/llvm-project/commit/418f780f1f882dbe4f72fcbd3b24b2ce34520557.diff

LOG: [NFC][SCEV] Reflow `computeSCEVAtScope()` into an exhaustive switch

Added: 
    

Modified: 
    llvm/lib/Analysis/ScalarEvolution.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 3e2cdb3e66b3..4c1491b4c0c3 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -9849,18 +9849,32 @@ const SCEV *ScalarEvolution::computeSCEVAtScope(const SCEV *V, const Loop *L) {
           OpAtScope = getSCEVAtScope(Ops[i], L);
           NewOps.push_back(OpAtScope);
         }
-        if (isa<SCEVCastExpr>(V))
+
+        switch (V->getSCEVType()) {
+        case scTruncate:
+        case scZeroExtend:
+        case scSignExtend:
+        case scPtrToInt:
           return getCastExpr(V->getSCEVType(), NewOps[0], V->getType());
-        if (isa<SCEVAddExpr>(V))
+        case scAddExpr:
           return getAddExpr(NewOps, cast<SCEVAddExpr>(V)->getNoWrapFlags());
-        if (isa<SCEVMulExpr>(V))
+        case scMulExpr:
           return getMulExpr(NewOps, cast<SCEVMulExpr>(V)->getNoWrapFlags());
-        if (isa<SCEVUDivExpr>(V))
+        case scUDivExpr:
           return getUDivExpr(NewOps[0], NewOps[1]);
-        if (isa<SCEVMinMaxExpr>(V))
+        case scUMaxExpr:
+        case scSMaxExpr:
+        case scUMinExpr:
+        case scSMinExpr:
           return getMinMaxExpr(V->getSCEVType(), NewOps);
-        if (isa<SCEVSequentialMinMaxExpr>(V))
+        case scSequentialUMinExpr:
           return getSequentialMinMaxExpr(V->getSCEVType(), NewOps);
+        case scConstant:
+        case scAddRecExpr:
+        case scUnknown:
+        case scCouldNotCompute:
+          llvm_unreachable("Can not get those expressions here.");
+        }
         llvm_unreachable("Unknown n-ary-like SCEV type!");
       }
     }