[PATCH] D141777: [X86] Reenable store merging post-legalization

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a reviewer: TokarIP.
RKSimon added a subscriber: TokarIP.
RKSimon added a comment.

CC'ing @TokarIP who recently added the light-avx tuning flag for something similar.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h:247
+  bool mergeStoresAfterLegalization(
+      EVT, std::optional<StoreSource> StoreSrc) const override {
+    return false;
----------------
drop unused StoreSrc?
```
mergeStoresAfterLegalization(EVT, std::optional<StoreSource>)
```


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:1077
+        EVT MemVT, std::optional<StoreSource> StoreSrc) const override {
+      return !StoreSrc || StoreSrc != StoreSource::ExtractSubvector;
     }
----------------
should we play safe and treat unknown as a potential extractsubvector?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141777/new/

https://reviews.llvm.org/D141777