[llvm] 82ba958 - [Attributor] Handle constant icmp expressions in AAPotentialValues
Johannes Doerfert via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 22 01:15:47 PST 2023
Author: Johannes Doerfert
Date: 2023-01-22T01:15:38-08:00
New Revision: 82ba958ca2ee939910168fc1f123003c96c0221e
URL: https://github.com/llvm/llvm-project/commit/82ba958ca2ee939910168fc1f123003c96c0221e
DIFF: https://github.com/llvm/llvm-project/commit/82ba958ca2ee939910168fc1f123003c96c0221e.diff
LOG: [Attributor] Handle constant icmp expressions in AAPotentialValues
A `ConstantExpr` ICmp is pretty much the same thing as an ICmpInst when
we want to simplify it. We just need to be less restrictive wrt. the
type and use the static helper functions directly.
Fixes: https://github.com/llvm/llvm-project/issues/59767
Added:
Modified:
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
llvm/test/Transforms/Attributor/value-simplify.ll
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/IPO/AttributorAttributes.cpp b/llvm/lib/Transforms/IPO/AttributorAttributes.cpp
index 5830426c20736..f9a105823f72c 100644
--- a/llvm/lib/Transforms/IPO/AttributorAttributes.cpp
+++ b/llvm/lib/Transforms/IPO/AttributorAttributes.cpp
@@ -10347,7 +10347,9 @@ struct AAPotentialValuesImpl : AAPotentialValues {
return;
}
Value *Stripped = getAssociatedValue().stripPointerCasts();
- if (isa<Constant>(Stripped)) {
+ auto *CE = dyn_cast<ConstantExpr>(Stripped);
+ if (isa<Constant>(Stripped) &&
+ (!CE || CE->getOpcode() != Instruction::ICmp)) {
addValue(A, getState(), *Stripped, getCtxI(), AA::AnyScope,
getAnchorScope());
indicateOptimisticFixpoint();
@@ -10549,10 +10551,9 @@ struct AAPotentialValuesFloating : AAPotentialValuesImpl {
/// We handle multiple cases, one in which at least one operand is an
/// (assumed) nullptr. If so, try to simplify it using AANonNull on the other
/// operand. Return true if successful, in that case Worklist will be updated.
- bool handleCmp(Attributor &A, CmpInst &Cmp, ItemInfo II,
+ bool handleCmp(Attributor &A, Value &Cmp, Value *LHS, Value *RHS,
+ CmpInst::Predicate Pred, ItemInfo II,
SmallVectorImpl<ItemInfo> &Worklist) {
- Value *LHS = Cmp.getOperand(0);
- Value *RHS = Cmp.getOperand(1);
// Simplify the operands first.
bool UsedAssumedInformation = false;
@@ -10574,20 +10575,20 @@ struct AAPotentialValuesFloating : AAPotentialValuesImpl {
return false;
RHS = *SimplifiedRHS;
- LLVMContext &Ctx = Cmp.getContext();
+ LLVMContext &Ctx = LHS->getContext();
// Handle the trivial case first in which we don't even need to think about
// null or non-null.
- if (LHS == RHS && (Cmp.isTrueWhenEqual() || Cmp.isFalseWhenEqual())) {
- Constant *NewV =
- ConstantInt::get(Type::getInt1Ty(Ctx), Cmp.isTrueWhenEqual());
+ if (LHS == RHS &&
+ (CmpInst::isTrueWhenEqual(Pred) || CmpInst::isFalseWhenEqual(Pred))) {
+ Constant *NewV = ConstantInt::get(Type::getInt1Ty(Ctx),
+ CmpInst::isTrueWhenEqual(Pred));
addValue(A, getState(), *NewV, /* CtxI */ nullptr, II.S,
getAnchorScope());
return true;
}
// From now on we only handle equalities (==, !=).
- ICmpInst *ICmp = dyn_cast<ICmpInst>(&Cmp);
- if (!ICmp || !ICmp->isEquality())
+ if (!CmpInst::isEquality(Pred))
return false;
bool LHSIsNull = isa<ConstantPointerNull>(LHS);
@@ -10604,14 +10605,13 @@ struct AAPotentialValuesFloating : AAPotentialValuesImpl {
// The index is the operand that we assume is not null.
unsigned PtrIdx = LHSIsNull;
auto &PtrNonNullAA = A.getAAFor<AANonNull>(
- *this, IRPosition::value(*ICmp->getOperand(PtrIdx)),
- DepClassTy::REQUIRED);
+ *this, IRPosition::value(*(PtrIdx ? RHS : LHS)), DepClassTy::REQUIRED);
if (!PtrNonNullAA.isAssumedNonNull())
return false;
// The new value depends on the predicate, true for != and false for ==.
- Constant *NewV = ConstantInt::get(Type::getInt1Ty(Ctx),
- ICmp->getPredicate() == CmpInst::ICMP_NE);
+ Constant *NewV =
+ ConstantInt::get(Type::getInt1Ty(Ctx), Pred == CmpInst::ICMP_NE);
addValue(A, getState(), *NewV, /* CtxI */ nullptr, II.S, getAnchorScope());
return true;
}
@@ -10812,7 +10812,8 @@ struct AAPotentialValuesFloating : AAPotentialValuesImpl {
SmallVectorImpl<ItemInfo> &Worklist,
SmallMapVector<const Function *, LivenessInfo, 4> &LivenessAAs) {
if (auto *CI = dyn_cast<CmpInst>(&I))
- if (handleCmp(A, *CI, II, Worklist))
+ if (handleCmp(A, *CI, CI->getOperand(0), CI->getOperand(1),
+ CI->getPredicate(), II, Worklist))
return true;
switch (I.getOpcode()) {
@@ -10877,6 +10878,13 @@ struct AAPotentialValuesFloating : AAPotentialValuesImpl {
continue;
}
+ if (auto *CE = dyn_cast<ConstantExpr>(V)) {
+ if (CE->getOpcode() == Instruction::ICmp)
+ if (handleCmp(A, *CE, CE->getOperand(0), CE->getOperand(1),
+ CmpInst::Predicate(CE->getPredicate()), II, Worklist))
+ continue;
+ }
+
if (auto *I = dyn_cast<Instruction>(V)) {
if (simplifyInstruction(A, *I, II, Worklist, LivenessAAs))
continue;
diff --git a/llvm/test/Transforms/Attributor/value-simplify.ll b/llvm/test/Transforms/Attributor/value-simplify.ll
index 75a6b77e1a8fc..65c4483cfda24 100644
--- a/llvm/test/Transforms/Attributor/value-simplify.ll
+++ b/llvm/test/Transforms/Attributor/value-simplify.ll
@@ -7,9 +7,11 @@ declare void @f(i32)
declare token @llvm.call.preallocated.setup(i32)
declare ptr @llvm.call.preallocated.arg(token, i32)
+ at str = private unnamed_addr addrspace(4) constant [1 x i8] c"\00", align 1
@ConstAS3Ptr = addrspace(3) global i32 0, align 4
;.
+; CHECK: @[[STR:[a-zA-Z0-9_$"\\.-]+]] = private unnamed_addr addrspace(4) constant [1 x i8] zeroinitializer, align 1
; CHECK: @[[CONSTAS3PTR:[a-zA-Z0-9_$"\\.-]+]] = addrspace(3) global i32 0, align 4
; CHECK: @[[S:[a-zA-Z0-9_$"\\.-]+]] = external global [[STRUCT_X:%.*]]
; CHECK: @[[G:[a-zA-Z0-9_$"\\.-]+]] = internal constant { [2 x ptr] } { [2 x ptr] [ptr @f1, ptr @f2] }
@@ -1407,6 +1409,24 @@ entry:
ret void
}
+define i1 @constexpr_icmp1() {
+; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
+; CHECK-LABEL: define {{[^@]+}}@constexpr_icmp1
+; CHECK-SAME: () #[[ATTR1]] {
+; CHECK-NEXT: ret i1 true
+;
+ ret i1 icmp ne (ptr addrspacecast (ptr addrspace(4) @str to ptr), ptr null)
+}
+
+define i1 @constexpr_icmp2() {
+; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
+; CHECK-LABEL: define {{[^@]+}}@constexpr_icmp2
+; CHECK-SAME: () #[[ATTR1]] {
+; CHECK-NEXT: ret i1 false
+;
+ ret i1 icmp eq (ptr addrspacecast (ptr addrspace(4) @str to ptr), ptr null)
+}
+
;.
; TUNIT: attributes #[[ATTR0:[0-9]+]] = { nocallback nofree nosync nounwind willreturn }
; TUNIT: attributes #[[ATTR1]] = { nofree norecurse nosync nounwind willreturn memory(none) }
More information about the llvm-commits
mailing list