[PATCH] D141030: [AMDGPU] Legalize soffset of buffer instruction. Use Waterfall loop logic.

[krishna chaitanya sankisa via Phabricator via llvm-commits]

skc7 added a comment.

In D141030#4059355 <https://reviews.llvm.org/D141030#4059355>, @arsenm wrote:

> I think this will mishandle the case where both the SRD and the soffset are VGPRs. You need to handle both at the same time in one waterfall loop (this should show up if your tests used a meaningful SRD). You can also just look into the globalisel tests for these intrinsics, they test all the permutations already

Made changes to legalize and use single water fall loop for rsrc and soffset. As per my understanding, SiFixSGPRCopies pass makes call to moveToVALU sequentially (not together for soffset and rsrc) for operands. So we see two water fall loops in the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141030/new/

https://reviews.llvm.org/D141030