[PATCH] D142279: [cmake] Use LLVM_ENABLE_ASSERTIONS to enable assertions in libstdc++

Sat Jan 21 07:34:13 PST 2023

nikic added a comment.

In D142279#4071141 <https://reviews.llvm.org/D142279#4071141>, @nikic wrote:

> As @barannikov88 pointed out, we should just be moving the existing block from EXPENSIVE_CHECKS though.

Ah no, having looked a bit closer, I think we want to have `-D_GLIBCXX_ASSERTIONS` in normal assertion enabled builds and `-DGLIBCXX_DEBUG` only under EXPENSIVE_CHECKS, so I think your implementation is about right as-is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142279/new/

https://reviews.llvm.org/D142279