[PATCH] D142253: [InstCombine] Transform ctpop(Pow2) -> icmp ne Pow2, 0

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:673
     return BinaryOperator::CreateLShr(
         Op0, ConstantInt::get(Ty, (~Known.Zero).exactLogBase2()));
 
----------------
goldstein.w.n wrote:
> nikic wrote:
> > If the new pattern reliably subsumes this one, we should drop it in a followup.
> > If the new pattern reliably subsumes this one, we should drop it in a followup.
> 
> Got it. I test removing it but remembered seeing some differences but didn't investigate deeply. I can add a `TODO` before i commit?
Sure, that's fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142253/new/

https://reviews.llvm.org/D142253