[PATCH] D140559: [InlineAdvisor] Restructure advisor plugin unittest cmake

Fri Jan 20 15:48:19 PST 2023

Jake-Egan added inline comments.

================
Comment at: llvm/unittests/Analysis/CMakeLists.txt:67
 target_link_libraries(AnalysisTests PRIVATE LLVMTestingSupport)

+add_subdirectory(InlineAdvisorPlugin)
----------------

================
Comment at: llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt:6-10
+  # On AIX, enable run-time linking to allow symbols from the plugins shared
+  # objects to be properly bound.
+  if(CMAKE_SYSTEM_NAME STREQUAL "AIX")
+    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-brtl")
+  endif()
----------------
The problem is that AnalysisTests is missing `-brtl` in the link step after this change. If you move this AIX related code back to the original file it will fix the problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140559/new/

https://reviews.llvm.org/D140559