[PATCH] D142254: [X86] Transform vector SET{LE/ULT/ULE} -> SETLT and SET{GE/UGT/UGE} -> SETGT if possible

Fri Jan 20 15:15:39 PST 2023

lebedev.ri added a comment.

In D142254#4070376 <https://reviews.llvm.org/D142254#4070376>, @goldstein.w.n wrote:

> In D142254#4070259 <https://reviews.llvm.org/D142254#4070259>, @RKSimon wrote:
>
>> This feels like we could easily make this a generic DAG fold with a suitable TLI callback to help determine the preferred CondCode (or just signed/unsigned).
>
> What where you thinking the API would be? I can see it being easy to represent "prefered signed/unsigned" but have trouble seeing a clean and generic
> API for only if `LT`/`GT` but NOT for `LE`/`GE`.

Sounds like the hook should just take the current CC and return the preferred one?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142254/new/

https://reviews.llvm.org/D142254