[PATCH] D98213: [InlineCost] Enable the cost benefit analysis on FDO

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 14:37:29 PST 2023


wenlei added a comment.

> The feature caims to compare the performance gains by measuring the cycles saved from a PGO run, and comparing against some threshold. This doesn't make sense since the length of the runs for PGO are arbitrary, and you shouldn't be using them in absolute terms.

IIUC, hot threshold is being taken into account in the formula (at the very end of `costBenefitAnalysis`), so this is affected by relative hotness only. It's just like how pgo counts are used and supposed to be used anywhere else in the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98213/new/

https://reviews.llvm.org/D98213



More information about the llvm-commits mailing list