[PATCH] D141755: [Bazel] Provide filegroups for `@rules_pkg`
NAKAMURA Takumi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 14:27:58 PST 2023
chapuni added a comment.
@GMNGeoffrey Thanks for the comment.
I could add actual tar rules as an example to use files, in `utils/bazel/BUILD.bazel` or other directory like `//pkg` outside `@llvm-project`.
I didn't do since I was afraid if they were less useful to everyone.
Do you think the commit log would satisfy an explanation of this? (I think so since I often use git-blame)
FYI, pkg_files can be used for bootstrapping clang if also toolchain files are supplied.
I would like to ask you. Is the location of `pkg_files` reasonable? I tried locating them to other places in `@llvm-project`,
- `//:` (`BUILD.bazel`) -- It requires modifying the repository rule for `llvm-raw`
- `//pkg:` or `//{clang|lld|llvm}:` -- Seems the overlay script doesn't accept new directories defined in `llvm-project-mirror`.
Since I suppose `pkg_files` rules would not affect wildcard target specifications from command line,
I have taken an option to locate pkg_files into existing `BUILD.bazel`.
Other options?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141755/new/
https://reviews.llvm.org/D141755
More information about the llvm-commits
mailing list