[PATCH] D142240: [LSR] Generalize one aspect of terminator folding (recently introduced in D132443)

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-term-fold.ll:154
+; CHECK-NEXT:    [[TMP2:%.*]] = call ptr @foo(ptr [[TMP1]])
+; CHECK-NEXT:    [[INCDEC_PTR]] = getelementptr inbounds ptr, ptr [[DST_04]], i64 1
+; CHECK-NEXT:    [[LSR_FOLD_TERM_COND_REPLACED_TERM_COND:%.*]] = icmp eq ptr [[INCDEC_PTR]], [[UGLYGEP]]
----------------
nikic wrote:
> This is a miscompile, but you are already know that...
I actually hadn't noticed.  But yes, that's one of the issued I'd called out on the original review.  :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142240/new/

https://reviews.llvm.org/D142240