[PATCH] D141970: [Clang][LLD] Add --lto-CGO[0-3] option

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 11:24:34 PST 2023


scott.linder added inline comments.


================
Comment at: lld/MachO/Arch/ARM.cpp:32
                             const relocation_info) const override;
-  void relocateOne(uint8_t *loc, const Reloc &, uint64_t va,
+  void relocateOne(uint8_t *loc, const macho::Reloc &, uint64_t va,
                    uint64_t pc) const override;
----------------
yaxunl wrote:
> this change seems not related to the patch. same as below
Right, it is just a side-effect of not being able to forward-declare `CodeGenOpt::Level` in `lld/MachO/Config.h`, and the coincidence that `llvm/Support/CodeGen.h` also defines a type called `Reloc`.

I can move it into another NFC patch if that is preferrable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141970/new/

https://reviews.llvm.org/D141970



More information about the llvm-commits mailing list