[PATCH] D142237: [AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:334
+address spaces, for example as an argument to the ``DW_OP_xderef*`` operations.
+A new section that defines address classes is added (see
+:ref:`amdgpu-dwarf-address-spaces`).
----------------
Is the use of "class" intentional here? I thought we were not touching "address class" at all.


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:702
+AMDGPU supports languages, such as OpenCL, that define source language memory
+classes. Support is added to define language specific memory spaces so they can
+be used in a consistent way by consumers. See :ref:`amdgpu-dwarf-memory-spaces`.
----------------
Same question here, is this intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142237/new/

https://reviews.llvm.org/D142237