[PATCH] D142161: [LegacyDivergenceAnalysis] Add NewPM support

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 added inline comments.


================
Comment at: llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp:421
+  auto *TTI = AM.getCachedResult<TargetIRAnalysis>(F);
+  if (!TTI || !TTI->hasBranchDivergence())
+    return PreservedAnalyses::all();
----------------
arsenm wrote:
> gandhi21299 wrote:
> > arsenm wrote:
> > > No TTI probably shouldn’t be allowed 
> > L421 already checks for that, doesn't it?
> I'm saying it shouldn't need to. What happens if you run opt without a triple?
After the changes I just made, LegacyDA withdraws at L419 when `-mtriple=...` is not passed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142161/new/

https://reviews.llvm.org/D142161