[PATCH] D141830: [NFC] Use new version of SelectionDAG::getLoad in NVPTX LowerFormalArguments

Fri Jan 20 10:30:44 PST 2023

tra added a comment.

In D141830#4068313 <https://reviews.llvm.org/D141830#4068313>, @gchatelet wrote:

> You can see the original RFC <https://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html> to see why this can be beneficial.

Ah. Now the patch does make sense. Sorry about the push back.

================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:2751-2752
+            Alignment = Align(1);
+          SDValue P = DAG.getLoad(VecVT, dl, Root, VecAddr,
+                                  MachinePointerInfo(srcValue), Alignment,
+                                  MachineMemOperand::MODereferenceable |
----------------
I'd just fold it into the call itself.

```
SDValue P = DAG.getLoad(VecVT, dl, Root, VecAddr,
                                  MachinePointerInfo(srcValue), MaybeAlign(aggregateIsPacked ? 1 : 0),
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141830/new/

https://reviews.llvm.org/D141830