[PATCH] D142234: [LVI] Handle Intrinsic::ctlz

Antonio Frighetto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 09:41:49 PST 2023


antoniofrighetto added inline comments.


================
Comment at: llvm/test/Analysis/LazyValueAnalysis/lvi-for-ctlz.ll:32
+}
+
+declare i32 @llvm.ctlz.i32(i32, i1 immarg) nounwind willreturn
----------------
arsenm wrote:
> Test looks pretty small for all the different paths in the patch. You don't test the i1 false case for example
For the second argument `i1 false` the result should always be more precise than the current one, but I'll make sure to test it soon as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142234/new/

https://reviews.llvm.org/D142234



More information about the llvm-commits mailing list