[PATCH] D142214: [MC] Do not copy MCInstrDescs. NFC.

Fri Jan 20 08:16:50 PST 2023

foad added inline comments.

================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVMCCodeEmitter.cpp:64
 static bool hasType(const MCInst &MI, const MCInstrInfo &MII) {
-  MCInstrDesc MCDesc = MII.get(MI.getOpcode());
+  MCInstrDesc &MCDesc = MII.get(MI.getOpcode());
   // If we define an output, and have at least one other argument.
----------------
barannikov88 wrote:
> Doesn't this trigger compilation error (missing `const`)?
> 
Yes! Apparently you have to enable this target via LLVM_EXPERIMENTAL_TARGETS_TO_BUILD and I did not test that. Thanks for spotting it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142214/new/

https://reviews.llvm.org/D142214