[PATCH] D142211: [LangRef] Require i8s to be naturally aligned
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 07:50:16 PST 2023
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/IR/DataLayout.cpp:409
return reportError("Invalid ABI alignment, must be a power of 2");
+ if (Size == 8 && ABIAlign != 1)
+ return reportError(
----------------
I'd suggest adding an `AlignType == INTEGER_ALIGN &&` here. Probably doesn't matter in practice, but that limits it more explicitly to `i8`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142211/new/
https://reviews.llvm.org/D142211
More information about the llvm-commits
mailing list