[PATCH] D139774: [libclang] Add API to set temporary directory location

[Erich Keane via Phabricator via llvm-commits]

erichkeane added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:1450
 
 void system_temp_directory(bool ErasedOnReboot, SmallVectorImpl<char> &Result) {
   Result.clear();
----------------
So I was asked to take a look at this, and I believe that changing this function is absolutely the wrong approach.  The purpose of this API is to be used to get what the system/terminal owner has set as the temporary directory.  Allowing a user of the API to change the meaning of this is improper.

If we want to change where certain files are stored, the logic for that needs to happen at a higher level than this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139774/new/

https://reviews.llvm.org/D139774