[PATCH] D142216: [MC] Store number of implicit operands in MCInstrDesc. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 07:36:55 PST 2023


foad added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:209
+  unsigned char NumImplicitDefs; // Num of regs implicitly defined
   uint64_t Flags;                // Flags identifying machine instr class
   uint64_t TSFlags;              // Target Specific Flag values
----------------
arsenm wrote:
> Could these be reordered to avoid the alignment padding?
You could avoid some internal padding but I don't think you could make the struct any smaller overall.

I didn't worry too much about the exact layout of this struct until the end of the whole stack of patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142216/new/

https://reviews.llvm.org/D142216



More information about the llvm-commits mailing list