[PATCH] D142214: [MC] Do not copy MCInstrDescs. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 07:32:20 PST 2023


foad added a subscriber: dblaikie.
foad added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:200
 public:
+  MCInstrDesc(const MCInstrDesc &) = delete;
+
----------------
@dblaikie or any other C++ experts - does this seem reasonable? I was not sure if I should be following some kind of rule-of-3/5/7/11/13/... here. All I want to do is prevent users from //accidentally// writing `MCInstrDesc MCID = ...` instead of `const MCInstrDesc &MCID = ...`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142214/new/

https://reviews.llvm.org/D142214



More information about the llvm-commits mailing list