[PATCH] D142213: [MC] Make more use of MCInstrDesc::operands. NFC.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 07:29:19 PST 2023
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5126
if (!SGPRsUsed.count(SGPR) &&
- usesConstantBus(MRI, Op, InstDesc.OpInfo[i])) {
+ // FIXME: This can access off the end of the operands() array.
+ usesConstantBus(MRI, Op, InstDesc.operands().begin()[i])) {
----------------
Just wanted to highlight this pre-existing bug, which I did not feel like trying to fix as part of this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142213/new/
https://reviews.llvm.org/D142213
More information about the llvm-commits
mailing list