[PATCH] D142194: [AMDGPU][AsmParser] Fix matching immediate literals.
    Ivan Kosarev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jan 20 06:31:01 PST 2023
    
    
  
kosarev added a comment.
> If there's a literal parsing issue seems like it should be straightforward?
There is no reproducer, and even if we have one, it would still be not reliable, because the order in which the internal AsmParser machinery tries to match operands is generally beyond our control.
What's interesting about this change is that `defaultSMRDOffset8()` and `defaultSMRDLiteralOffset()` are not updated to add `ImmTyNone` operands instead of `ImmTyOffset` and we still pass the tests. That's because we don't really have any GFX6 tests with these operands dropped, so no default values used.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142194/new/
https://reviews.llvm.org/D142194
    
    
More information about the llvm-commits
mailing list