[PATCH] D142161: [LegacyDivergenceAnalysis] Add NewPM support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 05:58:23 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp:421
+  auto *TTI = AM.getCachedResult<TargetIRAnalysis>(F);
+  if (!TTI || !TTI->hasBranchDivergence())
+    return PreservedAnalyses::all();
----------------
gandhi21299 wrote:
> arsenm wrote:
> > No TTI probably shouldn’t be allowed 
> L421 already checks for that, doesn't it?
I'm saying it shouldn't need to. What happens if you run opt without a triple?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142161/new/

https://reviews.llvm.org/D142161



More information about the llvm-commits mailing list