[PATCH] D142027: [Assignment Tracking][NFC] Replace LLVM command line option with a new module flag

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando marked an inline comment as done.
Orlando added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfo.h:295
 class AssignmentTrackingPass : public PassInfoMixin<AssignmentTrackingPass> {
-public:
   void runOnFunction(Function &F);
+
----------------
CarlosAlbertoEnciso wrote:
> Any reason for the change to `private`?
`runOnFunction` doesn't itself set the module flag - the other two `run` methods call `runOnFunction` then set the module flag themselves, so that in the case of the Module override it is only set once. I've made `runOnFunction` private to avoid the pass functionality being used without the module flag being set. IMO it should always have been private anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142027/new/

https://reviews.llvm.org/D142027