[PATCH] D142191: [lld][RISCV] Merge subtarget features to get right attributes section

Elena Lepilkina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 04:06:55 PST 2023


eklepilkina added a comment.

> Target features in a function must not leak outside a function.

All target extensions are placed there and there is already such usage in https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/RISCV/RISCVTargetMachine.cpp#L127. Where should I get extensions information in bitcode file from?

Unfortuantely, I can't find now the comment in code, but I exactly remember the comment that target features for linker in taken from bitcode functions attributes + if `-mattr` is provided is taken from there also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142191/new/

https://reviews.llvm.org/D142191



More information about the llvm-commits mailing list