[PATCH] D133943: [Utils] Match function return type and other attributes on the definition in update_cc_test_checks

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

@arichardson @jdoerfert: I'm really keen to move this forward in some way, as without a change along these lines landing RISC-V ABI fixes is very painful. I'm happy to do the work to get this in a form that can be landed, but it would be great to get a clear steer in one direction or another so as to not waste time.

At this point, I see a couple of options:

- Go ahead and land this basically as written (changing the default behaviour for --function-signature in update_cc_test_checks. It doesn't touch update_llc_test_checks, as it's less clear that's useful, but I can explore if desired). Update all affected in-tree tests.
- Change tack, and introduced a `--full-function-signature` argument for update_cc_test_checks that will check the return value. I can use that for the tests refactoring I want to land, and in the future --function-signature might be updated to be an alias for --full-function-signature.

What do you think of either of the above paths, or do you have other ideas in mind? Many thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133943/new/

https://reviews.llvm.org/D133943