[PATCH] D142093: [InstCombine] trunc (fptoui|fptosi)

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:506
+    // simple types while evaluating truncations.
+    if (isGuaranteedNotToBeUndefOrPoison(I->getOperand(0)))
+      if (I->getOperand(0)->getType()->getScalarType()->isHalfTy())
----------------
samparker wrote:
> And I'm still not sure whether this is needed? Alive seems to want it to be happy, but I pretty sure integer transforms are performed elsewhere without considering fp-to-int conversions as inputs.
Can you share the problematic proof? It shouldn't be needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142093/new/

https://reviews.llvm.org/D142093