[PATCH] D142146: [IR] Avoid creation of GEPs into vectors (in one place)
Jannik Silvanus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 03:12:23 PST 2023
jsilvanus added a comment.
Thanks for the review.
Your example of accessing a known pointer in a vector is interesting.
For the sake of completeness, it would be possible to restrict this patch to vectors of overaligned elements, which would still fix the first issue in the test case, but avoid possible regressions you mentioned.
But based on the discourse discussion I did not do that because it would introduce a pooly tested special case.
Moreover, none of the existing test cases is affected by the change, which I also took as an indication that performance regressions would be unlikely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142146/new/
https://reviews.llvm.org/D142146
More information about the llvm-commits
mailing list