[PATCH] D142194: [AMDGPU][AsmParser] Fix matching immediate literals.
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 02:11:55 PST 2023
kosarev created this revision.
kosarev added reviewers: dp, rampitec, arsenm, foad.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
kosarev requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D142194
Files:
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
Index: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
+++ llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
@@ -347,6 +347,8 @@
return isImm() && Imm.Type == ImmT;
}
+ bool isImmLiteral() const { return isImmTy(ImmTyNone); }
+
bool isImmModifier() const {
return isImm() && Imm.Type != ImmTyNone;
}
@@ -7942,7 +7944,7 @@
//===----------------------------------------------------------------------===//
bool AMDGPUOperand::isSMRDOffset8() const {
- return isImm() && isUInt<8>(getImm());
+ return isImmLiteral() && isUInt<8>(getImm());
}
bool AMDGPUOperand::isSMEMOffset() const {
@@ -7953,7 +7955,7 @@
bool AMDGPUOperand::isSMRDLiteralOffset() const {
// 32-bit literals are only supported on CI and we only want to use them
// when the offset is > 8-bits.
- return isImm() && !isUInt<8>(getImm()) && isUInt<32>(getImm());
+ return isImmLiteral() && !isUInt<8>(getImm()) && isUInt<32>(getImm());
}
AMDGPUOperand::Ptr AMDGPUAsmParser::defaultSMRDOffset8() const {
@@ -8439,11 +8441,11 @@
}
bool AMDGPUOperand::isS16Imm() const {
- return isImm() && (isInt<16>(getImm()) || isUInt<16>(getImm()));
+ return isImmLiteral() && (isInt<16>(getImm()) || isUInt<16>(getImm()));
}
bool AMDGPUOperand::isU16Imm() const {
- return isImm() && isUInt<16>(getImm());
+ return isImmLiteral() && isUInt<16>(getImm());
}
//===----------------------------------------------------------------------===//
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142194.490757.patch
Type: text/x-patch
Size: 1579 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230120/b7829ab9/attachment.bin>
More information about the llvm-commits
mailing list