[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 02:10:08 PST 2023


barannikov88 added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:213
 /// to duplicate their names all over the place.
-static const char StartAfterOptName[] = "start-after";
-static const char StartBeforeOptName[] = "start-before";
-static const char StopAfterOptName[] = "stop-after";
-static const char StopBeforeOptName[] = "stop-before";
+static const StringLiteral StartAfterOptName = "start-after";
+static const StringLiteral StartBeforeOptName = "start-before";
----------------
>From the comment near StringLiteral:
> StringLiteral should *only* be used in a constexpr context, as such:
> constexpr StringLiteral S("test");



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142181/new/

https://reviews.llvm.org/D142181



More information about the llvm-commits mailing list