[PATCH] D141264: [AVR] Fix incorrect expansion of pseudo instructions LPMWRdZ/ELPMWRdZ

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 01:19:32 PST 2023


benshi001 added a comment.

In D141264#4065547 <https://reviews.llvm.org/D141264#4065547>, @aykevl wrote:

> This code modifies the pointer register, without restoring it. The pointer register should be restored to the previous value if it is is not killed (subtract one from the pointer value). See the expansion of LDDWRdPtrQ for avrtiny for example.

Thanks for your suggestion. I have added restoring the Z pointer register, and corresponding tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141264/new/

https://reviews.llvm.org/D141264



More information about the llvm-commits mailing list