[PATCH] D141891: [VP][DAGCombiner] Introduce generalized pattern match for vp sdnodes.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 marked 3 inline comments as done.
fakepaper56 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:850
+
+  // Specialize based on number of operands.
+  SDValue getNode(unsigned Opcode, const SDLoc &DL, EVT VT) {
----------------
craig.topper wrote:
> For empty context, I think we can have a single getNode like this
> 
> ```
>   template <typename... ArgT>
>   SDValue getNode(ArgT &&... Args) {
>     return DAG.getNode(std::forward<ArgT>(Args)...);
>    }
> ```
> 
> Not sure if there's something similar we can do for the other VPMatchContext.
Thank you for providing the way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141891/new/

https://reviews.llvm.org/D141891