[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 22:52:29 PST 2023


serge-sans-paille created this revision.
serge-sans-paille added a reviewer: nikic.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
serge-sans-paille requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

StringMap are useful when we need to duplicate the key's memory. That's
not the case for llvm:🆑:Option because the keys are StringLiteral.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142181

Files:
  llvm/include/llvm/Support/CommandLine.h
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/lib/Support/CommandLine.cpp
  llvm/unittests/Support/CommandLineInit/CommandLineInitTest.cpp
  llvm/unittests/Support/CommandLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142181.490726.patch
Type: text/x-patch
Size: 15138 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230120/ac7b49e9/attachment.bin>


More information about the llvm-commits mailing list