[PATCH] D141074: [X86] Avoid converting u64 to f32 using x87 on Windows

Thu Jan 19 15:42:54 PST 2023

srj added a comment.

In D141074#4066869 <https://reviews.llvm.org/D141074#4066869>, @aeubanks wrote:

> this is causing us to get undefined symbol errors for ___floatundisf because we don't link in builtins on win32. not 100% sure on this, but I don't think we're expected to link against builtins on win32
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1408807

Same problem was injected into Halide. Are we expected to link in the builtins now? Halide is willing to follow Chrome's lead, but this seems like a surprising change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141074/new/

https://reviews.llvm.org/D141074