[PATCH] D138123: [Verifier][WinEH] Check funclet tokens on intrinsic calls that may lower to function calls

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 15:11:14 PST 2023


efriedma added a comment.

Would it make sense to check calls to non-intrinsic functions here?  I don't see any meaningful distinction between an intrinsic that will be lowered to a non-intrinsic call, vs. an actual call.

Would it make sense to allow dangling funclet tokens in unreachable code?  In particular, I'm concerned about cases where a bit of code is logically inside a funclet, but control flow simplification cuts it off from the funclet entry.  (WinEHPrepare will throw away unreachable code anyway, so it shouldn't care.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138123/new/

https://reviews.llvm.org/D138123



More information about the llvm-commits mailing list