[PATCH] D142083: [X86][NFC] Move MemoryFoldTable2Addr MemoryFoldTable0~4 into X86InstrFoldTables.def

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 13:51:40 PST 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86MemFoldTables.inc:2
+static const X86MemoryFoldTableEntry MemoryFoldTable2Addr[] = {
+{X86::ADD16ri8_DB,X86::ADD16mi8,TB_NO_REVERSE},
+{X86::ADD16ri_DB,X86::ADD16mi,TB_NO_REVERSE},
----------------
pengfei wrote:
> skan wrote:
> > pengfei wrote:
> > > Can we format this file, or at least add two spaces for it?
> > > Can we format this file, or at least add two spaces for it?
> > 
> > You mean one space after the first and the second comma?
> No, just
> ```
> static const X86MemoryFoldTableEntry MemoryFoldTable2Addr[] = {
>   {X86::ADD16ri8_DB,X86::ADD16mi8,TB_NO_REVERSE},
> ```
column alignment would be even better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142083/new/

https://reviews.llvm.org/D142083



More information about the llvm-commits mailing list