[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

Thu Jan 19 12:59:13 PST 2023

friss added a comment.

In D136651#4064474 <https://reviews.llvm.org/D136651#4064474>, @glandium wrote:

> In D136651#4064260 <https://reviews.llvm.org/D136651#4064260>, @glandium wrote:
>
>> This broke our mac builds with errors like:
>>
>>   ld64.lld: error: undefined symbol: CFRunLoopRun
>>   >>> referenced by tools/clang/tools/clang-stat-cache/CMakeFiles/clang-stat-cache.dir/clang-stat-cache.cpp.o:(symbol main+0x11be)
>>
>> (and many more symbols)
>
> Additional information: those are cross-compiled, and for some reason the `-framework CoreServices` in the CMakeLists.txt doesn't seem to make it to the command line, which is surprising because something similar works fine for e.g. dsymutil.

Thanks for the report, unfortunately I have no way of testing this setup. Any chance you can experiment on your side? DirectoryWatcher uses the came decency, I'm wondering why it's not an issue there. If it helps to revert the change while someone investigates, that's perfectly fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136651/new/

https://reviews.llvm.org/D136651